Force download script not handling files with spaces properly

Posted on 16th Feb 2014 07:03 pm by admin

I have a regular old php force download script, uses this code:

Code: header("Cache-Control: ");
header("Pragma: ");
header("Content-type: application/octet-stream");
header("Content-Disposition: attachment; filename="".$download.""");
header("Content-length:".(string)(filesize($path.$download)));
readfile($path.$download);
Where path is preset and $download is set by GET variables (don't worry, I've sanitized, I check the GET value against an array of acceptable filenames.) This works fine on my computer in both Internet Explorer and Firefox:

http://infectionist.com/music/

But I recently got the new Droid phone and found a bug. I cannot download files with spaces in the filename. I've tried everything I can think of and nothing is working. I even tried downloading a file with a space (failed), then renaming that file replacing the space with an underscore, then it worked. So I know that it's space handling that's the issue, I just can't figure out how to get around it!

The whole script is one that lists all the files in a directory that are of a certain extension (in this case mp3, wma, and wav). Each filename is put into an array, this array is used as the check against the GET variable's input. I then array_slice() the array to show 10 results per page. I foreach() the sliced array and print out information about the file, like filesize, filename, format, and a little icon. The filename is a link to download the file, printed like this:

<a href="?file=".urlencode($filename)."">

So spaces get replaced with a + sign in the URL, but get read as a space by the script. I think the problem lies with the readfile() line, I don't know why the Droid phone doesn't like it, but there HAS to be a way to fix this.

If someone, ANYONE, can help me, it will be very much appreciated.

Your Answer:

Login to answer

Other forums

Simple AND question
Hello,

I've got following code:

Code: if(strpos($row[13],"http://")

Format timestamp from mysql
When I tried this:
Code: date("m/d/Y H:i A", $row['timestamp'])
I got 12/31/1969 18:

Database connection failure
Hello All,

I am trying to create new connection to Oracle DB 10.1,
I could not see a

Is there something wrong?
Hi all,

Just a quick question... can someone look at this code and see if something is wrong?

some questions
Hello,

I am looking for the answers for following questions:

1) Does PHP support overl

PHP Code reffering to database, doing something wrong.. pls help
Well i am quite new with PHP
and for school we have to make a PHP script which reffers to a Data

SESSION CHECK WORKS "MOST" of the time... whats going on?
i have a sign in check thats included in every page that is a members only page which is basically a

Post PHP form to non-existing page
The company that I work for host their PHP code on IIS on a Windows server, no Apache, so no mod_rew

Bandwidth monitoring?
Hi guys,

I need a little information I have written a php app and I occurred to that I need

Share admin accross websites
I'm using .net memberships and roles in one of my sites, but I need to be able to share logins and p