Force download script not handling files with spaces properly

Posted on 16th Feb 2014 07:03 pm by admin

I have a regular old php force download script, uses this code:

Code: header("Cache-Control: ");
header("Pragma: ");
header("Content-type: application/octet-stream");
header("Content-Disposition: attachment; filename="".$download.""");
header("Content-length:".(string)(filesize($path.$download)));
readfile($path.$download);
Where path is preset and $download is set by GET variables (don't worry, I've sanitized, I check the GET value against an array of acceptable filenames.) This works fine on my computer in both Internet Explorer and Firefox:

http://infectionist.com/music/

But I recently got the new Droid phone and found a bug. I cannot download files with spaces in the filename. I've tried everything I can think of and nothing is working. I even tried downloading a file with a space (failed), then renaming that file replacing the space with an underscore, then it worked. So I know that it's space handling that's the issue, I just can't figure out how to get around it!

The whole script is one that lists all the files in a directory that are of a certain extension (in this case mp3, wma, and wav). Each filename is put into an array, this array is used as the check against the GET variable's input. I then array_slice() the array to show 10 results per page. I foreach() the sliced array and print out information about the file, like filesize, filename, format, and a little icon. The filename is a link to download the file, printed like this:

<a href="?file=".urlencode($filename)."">

So spaces get replaced with a + sign in the URL, but get read as a space by the script. I think the problem lies with the readfile() line, I don't know why the Droid phone doesn't like it, but there HAS to be a way to fix this.

If someone, ANYONE, can help me, it will be very much appreciated.

Your Answer:

Login to answer

Other forums

DELETE FROM not working deletes wrong row
Hello

I have the following code which i found but it doesnt work properly.. it comes up with

str_replace help
Hey there,

I'm a PHP newb, I'm having troubles with the str_replace function. I want to clean

private constructor
Hello,

Can we create a constructor as private? If yes, what is the use of it? If no, why can'

How to validate from 2 possible answers
Hi

I hope somebody can help me with what will probably be really simple, I'm pulling my hair

pull content
I have an existing page, domain/adverts.php which has a good PR. I've just rebuilt my site and the n

db entry based on primary key
My "topics" table contains 10 entires
*--------------*
topicid topic
------

My query is being run with no results.
I have this.

Code: function DropUser($duser_id, $user_email, $user_username) {

help understanding hidden input w/ php
hello i'm doing a tutorial where there are multiple forms for an edit page for a user to update thei

Inserting multiple records from single form
I've found a number of threads that deal with this issue, but I'm new to php and coding language so

HTAccess auto log in?
Hi all.

Too busy driving celebs about lately so I hope someone here can help me out.

I