Force download script not handling files with spaces properly

Posted on 16th Feb 2014 07:03 pm by admin

I have a regular old php force download script, uses this code:

Code: header("Cache-Control: ");
header("Pragma: ");
header("Content-type: application/octet-stream");
header("Content-Disposition: attachment; filename="".$download.""");
header("Content-length:".(string)(filesize($path.$download)));
readfile($path.$download);
Where path is preset and $download is set by GET variables (don't worry, I've sanitized, I check the GET value against an array of acceptable filenames.) This works fine on my computer in both Internet Explorer and Firefox:

http://infectionist.com/music/

But I recently got the new Droid phone and found a bug. I cannot download files with spaces in the filename. I've tried everything I can think of and nothing is working. I even tried downloading a file with a space (failed), then renaming that file replacing the space with an underscore, then it worked. So I know that it's space handling that's the issue, I just can't figure out how to get around it!

The whole script is one that lists all the files in a directory that are of a certain extension (in this case mp3, wma, and wav). Each filename is put into an array, this array is used as the check against the GET variable's input. I then array_slice() the array to show 10 results per page. I foreach() the sliced array and print out information about the file, like filesize, filename, format, and a little icon. The filename is a link to download the file, printed like this:

<a href="?file=".urlencode($filename)."">

So spaces get replaced with a + sign in the URL, but get read as a space by the script. I think the problem lies with the readfile() line, I don't know why the Droid phone doesn't like it, but there HAS to be a way to fix this.

If someone, ANYONE, can help me, it will be very much appreciated.

Your Answer:

Login to answer

Other forums

Image loading
Hi Developers,

I'm trying to display an image from images/image.gif getting the url from mysq

php automatically escaping single quotes
I'm trying to test out my security a bit and I've noticed that php is escaping my single quotes. For

Data Function is Its Not working IN IE8
This is my first time to use formums. I hope i can get solution for this problem. view plaincopy to

PHP form authentication
Hi guys,

what am trying to achieve is this: Whenever a user tries to login to my website, an

Need help-Error istream header declaration
Hi Everyone ,

I am having issue with istream declaration. I am new to C programming.
can a

Error in write byte array into document in SM58
Hi Gurus,

Getting the following error status in Transactional RFC (SM58) ..... *Error i

Email logic not working
I would like to send an email using the php email() function then if it does execute i.e sends i wou

Remote Database Access
Hey guys!!

OK, i'm used to only working with databases from the CPANEL, accessing phpMyAdmin

How to Detect it is public_html or httpdocs?
How to check whether it is cPanel or Plesk?

If it found public_html perform <?php incl

natcasesort works on one server but not on another
Hi

I have a problem that I was hoping that someone can help me with.

I'm trying to use