Force download script not handling files with spaces properly


Posted on 16th Feb 2014 07:03 pm by admin

I have a regular old php force download script, uses this code:

Code: header("Cache-Control: ");
header("Pragma: ");
header("Content-type: application/octet-stream");
header("Content-Disposition: attachment; filename="".$download.""");
header("Content-length:".(string)(filesize($path.$download)));
readfile($path.$download);
Where path is preset and $download is set by GET variables (don't worry, I've sanitized, I check the GET value against an array of acceptable filenames.) This works fine on my computer in both Internet Explorer and Firefox:

http://infectionist.com/music/

But I recently got the new Droid phone and found a bug. I cannot download files with spaces in the filename. I've tried everything I can think of and nothing is working. I even tried downloading a file with a space (failed), then renaming that file replacing the space with an underscore, then it worked. So I know that it's space handling that's the issue, I just can't figure out how to get around it!

The whole script is one that lists all the files in a directory that are of a certain extension (in this case mp3, wma, and wav). Each filename is put into an array, this array is used as the check against the GET variable's input. I then array_slice() the array to show 10 results per page. I foreach() the sliced array and print out information about the file, like filesize, filename, format, and a little icon. The filename is a link to download the file, printed like this:

<a href="?file=".urlencode($filename)."">

So spaces get replaced with a + sign in the URL, but get read as a space by the script. I think the problem lies with the readfile() line, I don't know why the Droid phone doesn't like it, but there HAS to be a way to fix this.

If someone, ANYONE, can help me, it will be very much appreciated.

No comments posted yet

Your Answer:

Login to answer
287 Like 37 Dislike
Previous forums Next forums
Other forums

[RESOLVED] Socket/Port remains open after app crashes
I'm having this problem with a networked app in vb.net.

If the program exits normally the por

in php, link returns to the line
When I add a link in a php page, the link word returns to the line (as a
would do)

Examp

New to mysqli library - Multiple query problem
Greetings,

I am writing a batch program that executes 3 queries on a single page. Using mysql

Problems generating word documents on server side for security reasons
I have a problem with word documentation generation when generating a word document (docx) with PHP.

How to sum these output values
Hi

I need sum the month totals
SELECT region_name, area_name ,SUM (CASE WHEN S

Good Programming and Web Design Books
Hi,

I recived a pm today from a fellow phpfreaker regarding php books, i replied with the fo

ClientScript.RegisterClientScriptBlock Issue
This is what I haveview plaincopy to clipboardprint?Protected Sub posrback_Click(ByVal sender As Obj

Parse error: syntax error, unexpected T_ELSEIF in /home/......html/item.php on l
I do not know what is wrong with this. Hope some one can help. I do nto want to post the entire site

Can't shake the "Warning: include()" error
I've just uploaded my site to a new server and where I have PHP include tags in my HTML, the browser

Change Web page language
i doing this thing first time but i dont find any suitable solution for it. On the demand of user. I

Sign up to write
Sign up now if you have flare of writing..
Login   |   Register
Follow Us
Indyaspeak @ Facebook Indyaspeak @ Twitter Indyaspeak @ Pinterest RSS



Play Free Quiz and Win Cash