Is there a more efficient way to code this than what I have?
Posted on
16th Feb 2014 07:03 pm by
admin
I have three associative arrays.
$combinedSettings
$userSettings
Did you know?Explore Trending and Topic pages for more stories like this.
$defaultSettings
My function must combine the key and value from $userSettings and $defaultSettings into the $combinedSettings array.
$userSettings will always contain more keys than $defaultSettings will ever have.
So every once in a while there is an extra key and of course it's value in the $userSettings array than in the $defaultSettings array.
If the value of a key in $userSettings is empty we then use the value for the same key in the $defaultSettings. Every key in $defaultSettings will always be present in $userSettings. $userSettings just adds a few extra keys and their values.
Below is my working code but I am wondering if there is some way to make it more efficient, faster, perhaps with less code. It looks rather clutzy to me. Rather bloated.
Code: while (list($userKey, $userValue) = each($userSettings)) {
while ($defaultKey = key($defaultSettings)) {
$defaultValue = current($defaultSettings);
if ($userKey === $defaultKey) {
if ($userValue === "") {
$combinedSettings[$defaultKey] = $defaultValue;
} else {
$combinedSettings[$userKey] = $userKey;
}
next($defaultSettings); // to allow key() to work properly above.
} else { // add userSettings setting and value to combinedSettings and leave
// defaultSettings where it is.
$combinedSettings[$userKey] = $userValue;
}
break;
}
}
Thanks.
No comments posted yet
Your Answer:
Login to answer
288
7
Other forums
Oracle Connectivity
Hi Every One,
Can we access SAP from oracle database.If it possible then please spec
Display the user's weight lost in the past week
Hello everyone,
I am working on a weight loss app for my site, and I want to display the user
reading partial code from external site
Hi,
I am trying to write a script for my website to get an article from an external website.
MII Trends - add data onto chart object
Hello,
Can anyone please provide some thoughts on my current requirement:
its pretty
Upload file and add HTML
Hey everyone,
I have a client has meeting agendas and minutes that should be posted online. I
Is it a good practice to store user info. in sessions?
I am making a user class for my script which stores all the user information in sessions. It takes u
send message to the java application
Oracle 10g with Windows platform.
I have a java application that periodically pings the d
Creating an invoice
Using fpdf I am trying to create an invoice to send to clients. The products are sold in pricing tie
first few characters only
hi, does anyone know how to use PHP to take the first few words of a text and limit them? i have see
weeks in a year
hi,
i found this snippet on php.net
QuoteFor the week number for weeks starting on Sunday: